ecere/gui/ListBox: Debugging code

- Setting current row does not check whether a row belongs to the ListBox;
  this can be the source of obscure bugs

diff --git a/ecere/src/gui/controls/ListBox.ec b/ecere/src/gui/controls/ListBox.ec
index cb5cb37..b0d0664 100644 (file)
--- a/ecere/src/gui/controls/ListBox.ec
+++ b/ecere/src/gui/controls/ListBox.ec
@@ -1986,8 +1986,52 @@ private:
       }
    }
 
+#ifdef _DEBUG
+   static bool DebugFindRow(DataRow parent, DataRow row)
+   {
+      bool found = false;
+      DataRow r;
+      for(r = parent.subRows.first; r; r = r.next)
+      {
+         if(r == row)
+         {
+            found = true;
+            break;
+         }
+         if(DebugFindRow(r, row))
+         {
+            found = true;
+            break;
+         }
+      }
+      return found;
+   }
+#endif
+
    void SetCurrentRow(DataRow row, bool notify)
    {
+#if _DEBUG
+      if(this && row)
+      {
+         bool found = false;
+         DataRow r;
+         for(r = rows.first; r; r = r.next)
+         {
+            if(r == row)
+            {
+               found = true;
+               break;
+            }
+            if(DebugFindRow(r, row))
+            {
+               found = true;
+               break;
+            }
+         }
+         if(!found)
+            PrintLn("ERROR: Setting currentRow to a row not found in ListBox!!");
+      }
+#endif
       if(this && (currentRow != row || (currentRow && currentRow.selectedFlag == unselected)))
       {
          int headerSize = ((style.header) ? rowHeight : 0);