define stringFrom = " from ";
// This function cannot accept same pointer for source and output
+// todo: rename ReplaceSpaces to EscapeSpaceAndSpecialChars or something
void ReplaceSpaces(char * output, char * source)
{
int c, dc;
for(c = 0, dc = 0; (ch = source[c]); c++, dc++)
{
if(ch == ' ') output[dc++] = '\\';
+ if(ch == '\"') output[dc++] = '\\';
+ if(ch == '&') output[dc++] = '\\';
if(pch != '$')
{
if(ch == '(' || ch == ')') output[dc++] = '\\';
output[dc] = '\0';
}
-// This function cannot accept same pointer for source and output
-void ReplaceUnwantedMakeChars(char * output, char * source)
-{
- int c, dc;
- char ch, pch = 0;
+// chars refused for project name: windowsFileNameCharsNotAllowed + " &,."
- for(c = 0, dc = 0; (ch = source[c]); c++, dc++)
+//define gnuMakeCharsNeedEscaping = "$%";
+
+//define windowsFileNameCharsNotAllowed = "*/:<>?\\\"|";
+//define linuxFileNameCharsNotAllowed = "/";
+
+//define windowsFileNameCharsNeedEscaping = " !%&'()+,;=[]^`{}~"; // "#$-.@_" are ok
+//define linuxFileNameCharsNeedEscaping = " !\"$&'()*:;<=>?[\\`{|"; // "#%+,-.@]^_}~" are ok
+
+// NOTES: - this function should get only unescaped unix style paths
+// - paths with literal $(somestring) in them are not supported
+// my_$(messed_up)_path would likely become my__path
+void EscapeForMake(char * output, char * input, bool hideSpace, bool allowVars, bool allowDblQuote)
+{
+ char ch, *i = input, *o = output;
+ bool inVar = false;
+#ifdef _DEBUG
+ int len = strlen(input);
+ if(len && ((input[0] == '"' && input[len-1] == '"') || strchr(input, '\\') || strchr(input, 127) || (!allowDblQuote && strchr(input, '"'))))
+ PrintLn("Invalid input for EscapeForMake! -- ", input);
+#endif
+ while((ch = *i++))
{
- if(pch != '$')
+ if(ch == '(')
{
- if(ch == '(' || ch == ')') output[dc++] = '\\';
- pch = ch;
+ if(i-1 != input && *(i-2) == '$' && allowVars)
+ inVar = true;
+ else
+ *o++ = '\\';
}
else if(ch == ')')
- pch = 0;
+ {
+ if(inVar == true && allowVars)
+ inVar = false;
+ else
+ *o++ = '\\';
+ }
+ else if(ch == '$' && *i != '(')
+ *o++ = '$';
+ else if(ch == '&')
+ *o++ = '\\';
+ else if(ch == '"')
+ *o++ = '\\';
if(ch == ' ')
- output[dc] = 127;
+ {
+ if(hideSpace)
+ *o++ = 127;
+ else
+ {
+ *o++ = '\\';
+ *o++ = ch;
+ }
+ }
else
- output[dc] = ch;
+ *o++ = ch;
}
- output[dc] = '\0';
+ *o = '\0';
}
-static void OutputNoSpace(File f, char * source)
+void EscapeForMakeToFile(File output, char * input, bool hideSpace, bool allowVars, bool allowDblQuote)
{
- char * output = new char[strlen(source)+1024];
- ReplaceSpaces(output, source);
- f.Puts(output);
- delete output;
+ char * buf = new char[strlen(input)*2+1];
+ EscapeForMake(buf, input, hideSpace, allowVars, allowDblQuote);
+ output.Print(buf);
+ delete buf;
}
-enum ListOutputMethod { inPlace, newLine, lineEach };
+void EscapeForMakeToDynString(DynamicString output, char * input, bool hideSpace, bool allowVars, bool allowDblQuote)
+{
+ char * buf = new char[strlen(input)*2+1];
+ EscapeForMake(buf, input, hideSpace, allowVars, allowDblQuote);
+ output.concat(buf);
+ delete buf;
+}
int OutputFileList(File f, char * name, Array<String> list, Map<String, int> varStringLenDiffs, char * prefix)
{
f.Printf("\t$(call rmq,$(%s))\n", name);
}
-void OutputListOption(File f, char * option, Array<String> list, ListOutputMethod method, bool noSpace)
+enum LineOutputMethod { inPlace, newLine, lineEach };
+enum StringOutputMethod { asIs, escape, escapePath};
+
+enum ToolchainFlag { any, _D, _I, _isystem, _Wl, _L/*, _Wl-rpath*/ };
+String flagNames[ToolchainFlag] = { "", "-D", "-I", "-isystem ", "-Wl,", "-Wl,--library-path="/*, "-Wl,-rpath "*/ };
+void OutputFlags(File f, ToolchainFlag flag, Array<String> list, LineOutputMethod lineMethod)
{
if(list.count)
{
- if(method == newLine)
+ if(lineMethod == newLine)
f.Puts(" \\\n\t");
for(item : list)
{
- if(method == lineEach)
+ if(lineMethod == lineEach)
f.Puts(" \\\n\t");
- f.Printf(" -%s", option);
- if(noSpace)
- OutputNoSpace(f, item);
+ f.Printf(" %s", flagNames[flag]);
+ if(flag != _D && flag != _Wl && flag != any)
+ {
+ char * tmp = new char[strlen(item)*2+1];
+ EscapeForMake(tmp, item, false, true, false);
+ f.Printf("$(call quote_path,%s)", tmp);
+ delete tmp;
+ }
else
- f.Printf("%s", item);
+ EscapeForMakeToFile(f, item, false, true, true);
}
}
}
-void StringNoSpaceToDynamicString(DynamicString s, char * path)
-{
- char * output = new char[strlen(path)+1024];
- ReplaceSpaces(output, path);
- s.concat(output);
- delete output;
-}
-
static void OutputLibraries(File f, Array<String> libraries)
{
for(item : libraries)
f.Puts(" \\\n\t$(call _L,");
usedFunction = true;
}
- OutputNoSpace(f, s);
+ EscapeForMakeToFile(f, s, false, false, false);
if(usedFunction)
f.Puts(")");
}
String compilerConfigsDir;
String moduleVersion;
+ String lastBuildConfigName;
+ String lastBuildCompilerName;
+
+ Map<String, NameCollisionInfo> lastBuildNamesInfo;
+
#ifndef MAKEFILE_GENERATOR
FileMonitor fileMonitor
{
if(MessageBox { type = yesNo, master = ide,
text = $"Project has been modified", contents = temp }.Modal() == yes)
{
- Project project = LoadProject(filePath, config.name);
+ Project project = LoadProject(filePath, config ? config.name : null);
if(project)
{
ProjectView projectView = ide.projectView;
delete filePath;
delete topNode;
delete name;
+ delete lastBuildConfigName;
+ delete lastBuildCompilerName;
+ if(lastBuildNamesInfo) { lastBuildNamesInfo.Free(); delete lastBuildNamesInfo; }
}
~Project()
topNode.info = CopyString(GetConfigName(config));
}
}
+
property char * filePath
{
set
}
}
+ ProjectConfig GetConfig(char * configName)
+ {
+ ProjectConfig result = null;
+ if(configName && configName[0] && configurations.count)
+ {
+ for(cfg : configurations; !strcmpi(cfg.name, configName))
+ {
+ result = cfg;
+ break;
+ }
+ }
+ return result;
+ }
+
+ ProjectNode FindNodeByObjectFileName(char * fileName, IntermediateFileType type, bool dotMain, ProjectConfig config)
+ {
+ ProjectNode result;
+ if(!lastBuildNamesInfo)
+ ProjectLoadLastBuildNamesInfo(this, config);
+ result = topNode.FindByObjectFileName(fileName, type, dotMain, lastBuildNamesInfo);
+ return result;
+ }
+
TargetTypes GetTargetType(ProjectConfig config)
{
TargetTypes targetType = localTargetType;
return false;
}
-
char * GetObjDirExpression(ProjectConfig config)
{
// TODO: Support platform options
int compilingEC = 0;
int numErrors = 0, numWarnings = 0;
bool loggedALine = false;
- char * configName = config ? config.name : "Common";
int lenMakeCommand = strlen(compiler.makeCommand);
int testLen = 0;
char * t;
precompiling = true;
}
// Changed escapeBackSlashes here to handle paths with spaces
- Tokenize(module, 1, tokens, true); // false);
+ Tokenize(module, 1, tokens, (BackSlashEscaping)true); // fix #139
GetLastDirectory(module, moduleName);
ide.outputView.buildBox.Logf("%s\n", moduleName);
}
if(module)
{
byte * tokens[1];
- Tokenize(module, 1, tokens, true);
+ Tokenize(module, 1, tokens, (BackSlashEscaping)true); // fix #139
GetLastDirectory(module, moduleName);
ide.outputView.buildBox.Logf("%s\n", moduleName);
}
{
if(linking || compiling || precompiling)
{
- char * colon = strstr(line, ":"); //, * bracket;
+ char * start = inFileIncludedFrom ? inFileIncludedFrom + strlen(stringInFileIncludedFrom) : from ? from + strlen(stringFrom) : line;
+ char * colon = strstr(start, ":"); //, * bracket;
if(colon && (colon[1] == '/' || colon[1] == '\\'))
colon = strstr(colon + 1, ":");
if(colon)
char moduleName[MAX_LOCATION], temp[MAX_LOCATION];
char * pointer;
char * error;
- char * start = inFileIncludedFrom ? inFileIncludedFrom + strlen(stringInFileIncludedFrom) : from ? from + strlen(stringFrom) : line;
int len = (int)(colon - start);
char ext[MAX_EXTENSION];
len = Min(len, MAX_LOCATION-1);
char targetFileName[MAX_LOCATION];
targetFileName[0] = '\0';
CatTargetFileName(targetFileName, compiler, config);
- ide.outputView.buildBox.Logf("\n%s (%s) - ", targetFileName, configName);
+ ide.outputView.buildBox.Logf("\n%s (%s) - ", targetFileName, lastBuildConfigName);
}
if(numErrors)
ide.outputView.buildBox.Logf("%d %s, ", numErrors, (numErrors > 1) ? $"errors" : $"error");
bool singleProjectOnlyNode = onlyNodes && onlyNodes.count == 1 && onlyNodes[0].type == project;
int numJobs = compiler.numJobs;
char command[MAX_F_STRING*4];
- char * compilerName;
+ char * compilerName = CopyString(compiler.name);
+
+ delete lastBuildConfigName;
+ lastBuildConfigName = CopyString(config ? config.name : "Common");
+ delete lastBuildCompilerName;
+ lastBuildCompilerName = CopyString(compiler.name);
+ ProjectLoadLastBuildNamesInfo(this, config);
- compilerName = CopyString(compiler.name);
CamelCase(compilerName);
strcpy(configName, config ? config.name : "Common");
int len;
char pushD[MAX_LOCATION];
char cfDir[MAX_LOCATION];
- Map<String, NameCollisionInfo> namesInfo { };
GetIDECompilerConfigsDir(cfDir, true, true);
GetWorkingDir(pushD, sizeof(pushD));
ChangeWorkingDir(topNode.path);
ChangeWorkingDir(pushD);
- topNode.GenMakefileGetNameCollisionInfo(namesInfo, config);
for(node : onlyNodes)
{
if(node.GetIsExcluded(config))
else
{
if(!eC_Debug)
- node.DeleteIntermediateFiles(compiler, config, bitDepth, namesInfo, mode == cObject ? true : false);
- node.GetTargets(config, namesInfo, objDirExp.dir, makeTargets);
+ node.DeleteIntermediateFiles(compiler, config, bitDepth, lastBuildNamesInfo, mode == cObject ? true : false);
+ node.GetTargets(config, lastBuildNamesInfo, objDirExp.dir, makeTargets);
}
}
- namesInfo.Free();
- delete namesInfo;
}
}
// Build(project, ideMain, true, null, false);
- #if defined(__WIN32__)
strcpy(target, topNode.path);
- #else
- strcpy(target, "");
- #endif
PathCatSlash(target, targetDirExp.dir);
CatTargetFileName(target, compiler, config);
sprintf(target, "%s %s", target, args);
fileName[0] = '\0';
if(targetType == staticLibrary || targetType == sharedLibrary)
strcat(fileName, "$(LP)");
- // !!! ReplaceSpaces must be done after all PathCat calls !!!
- // ReplaceSpaces(s, GetTargetFileName(config));
strcat(fileName, GetTargetFileName(config));
switch(targetType)
{
f.Printf("CXX := $(CCACHE_COMPILE)$(DISTCC_COMPILE)$(GCC_PREFIX)%s$(_SYSROOT)\n", compiler.cxxCommand);
f.Printf("ECP := $(if $(ECP_DEBUG),ide -debug-start \"$(ECERE_SDK_SRC)/compiler/ecp/ecp.epj\" -debug-work-dir \"${CURDIR}\" -@,%s)\n", compiler.ecpCommand);
f.Printf("ECC := $(if $(ECC_DEBUG),ide -debug-start \"$(ECERE_SDK_SRC)/compiler/ecc/ecc.epj\" -debug-work-dir \"${CURDIR}\" -@,%s)$(if $(CROSS_TARGET), -t $(TARGET_PLATFORM),)\n", compiler.eccCommand);
- f.Printf("ECS := $(if $(ECS_DEBUG),ide -debug-start \"$(ECERE_SDK_SRC)/compiler/ecs/ecs.epj\" -debug-work-dir \"${CURDIR}\" -@,%s)$(if $(CROSS_TARGET), -t $(TARGET_PLATFORM),)$(if $(OUTPUT_POT),-outputpot,)\n", compiler.ecsCommand);
+ f.Printf("ECS := $(if $(ECS_DEBUG),ide -debug-start \"$(ECERE_SDK_SRC)/compiler/ecs/ecs.epj\" -debug-work-dir \"${CURDIR}\" -@,%s)$(if $(CROSS_TARGET), -t $(TARGET_PLATFORM),)$(if $(OUTPUT_POT), -outputpot,)\n", compiler.ecsCommand);
f.Printf("EAR := %s\n", compiler.earCommand);
f.Puts("AS := $(GCC_PREFIX)as\n");
if(compiler.includeDirs && compiler.includeDirs.count)
{
f.Puts("\nCFLAGS +=");
- OutputListOption(f, gccCompiler ? "isystem " : "I", compiler.includeDirs, lineEach, true);
+ OutputFlags(f, gccCompiler ? _isystem : _I, compiler.includeDirs, lineEach);
f.Puts("\n");
}
if(compiler.prepDirectives && compiler.prepDirectives.count)
{
f.Puts("\nCFLAGS +=");
- OutputListOption(f, "D", compiler.prepDirectives, inPlace, true);
+ OutputFlags(f, _D, compiler.prepDirectives, inPlace);
f.Puts("\n");
}
if(compiler.libraryDirs && compiler.libraryDirs.count)
{
f.Puts("\nLDFLAGS +=");
- OutputListOption(f, "L", compiler.libraryDirs, lineEach, true);
+ OutputFlags(f, _L, compiler.libraryDirs, lineEach);
// We would need a bool option to know whether we want to add to rpath as well...
- // OutputListOption(f, "Wl,-rpath ", compiler.libraryDirs, lineEach, true);
+ // OutputFlags(f, _Wl-rpath, compiler.libraryDirs, lineEach);
f.Puts("\n");
}
if(compiler.excludeLibs && compiler.excludeLibs.count)
if(compiler.compilerFlags && compiler.compilerFlags.count)
{
f.Puts("\nCFLAGS +=");
- OutputListOption(f, "", compiler.compilerFlags, inPlace, true);
+ OutputFlags(f, any, compiler.compilerFlags, inPlace);
f.Puts("\n");
}
if(compiler.linkerFlags && compiler.linkerFlags.count)
{
f.Puts("\nLDFLAGS +=");
- OutputListOption(f, "Wl,", compiler.linkerFlags, inPlace, true);
+ OutputFlags(f, _Wl, compiler.linkerFlags, inPlace);
f.Puts("\n");
}
f.Puts("\n");
{
f.Puts(" \\\n\t ");
for(s : projectPlatformOptions.options.compilerOptions)
- {
f.Printf(" %s", s);
- }
}
if(configPlatformOptions && configPlatformOptions.options.compilerOptions && configPlatformOptions.options.compilerOptions.count)
{
f.Puts(" \\\n\t ");
for(s : configPlatformOptions.options.compilerOptions)
- {
f.Printf(" %s", s);
- }
}
f.Puts("\n");
f.Puts("\n");
{
f.Puts("OFLAGS +=");
if(configPlatformOptions && configPlatformOptions.options.libraryDirs)
- OutputListOption(f, "L", configPlatformOptions.options.libraryDirs, lineEach, true);
+ OutputFlags(f, _L, configPlatformOptions.options.libraryDirs, lineEach);
if(projectPlatformOptions && projectPlatformOptions.options.libraryDirs)
- OutputListOption(f, "L", projectPlatformOptions.options.libraryDirs, lineEach, true);
+ OutputFlags(f, _L, projectPlatformOptions.options.libraryDirs, lineEach);
f.Puts("\n");
}
- if((configPlatformOptions && configPlatformOptions.options.libraries))
+ if(configPlatformOptions && configPlatformOptions.options.libraries)
{
if(configPlatformOptions.options.libraries.count)
{
f.Puts("\n");
}
+ if((config && config.options && config.options.compilerOptions && config.options.compilerOptions.count) ||
+ (options && options.compilerOptions && options.compilerOptions.count))
+ {
+ f.Puts("CFLAGS +=");
+ f.Puts(" \\\n\t");
+
+ if(config && config.options && config.options.compilerOptions && config.options.compilerOptions.count)
+ {
+ for(s : config.options.compilerOptions)
+ f.Printf(" %s", s);
+ }
+ if(options && options.compilerOptions && options.compilerOptions.count)
+ {
+ for(s : options.compilerOptions)
+ f.Printf(" %s", s);
+ }
+ f.Puts("\n");
+ f.Puts("\n");
+ }
+
if((config && config.options && config.options.linkerOptions && config.options.linkerOptions.count) ||
(options && options.linkerOptions && options.linkerOptions.count))
{
f.Printf(",%s", s);
}
}
+ f.Puts("\n");
+ f.Puts("\n");
}
- f.Puts("\n");
- f.Puts("\n");
f.Puts("CECFLAGS += -cpp $(_CPP)");
f.Puts("\n");
f.Puts("ifndef STATIC_LIBRARY_TARGET\n");
f.Puts("OFLAGS +=");
if(config && config.options && config.options.libraryDirs)
- OutputListOption(f, "L", config.options.libraryDirs, lineEach, true);
+ OutputFlags(f, _L, config.options.libraryDirs, lineEach);
if(options && options.libraryDirs)
- OutputListOption(f, "L", options.libraryDirs, lineEach, true);
+ OutputFlags(f, _L, options.libraryDirs, lineEach);
f.Puts("\n");
f.Puts("endif\n");
f.Puts("\n");
if(!relObjDir)
f.Puts("\t$(if $(wildcard $(OBJ)),,$(call mkdirq,$(OBJ)))\n");
- f.Puts("\t$(if $(ECERE_SDK_SRC),$(if $(wildcard $(call escspace,$(ECERE_SDK_SRC)/crossplatform.mk)),,@$(call echo,Ecere SDK Source Warning: The value of ECERE_SDK_SRC is pointing to an incorrect ($(ECERE_SDK_SRC)/crossplatform.mk) location.)),)\n");
+ f.Puts("\t$(if $(ECERE_SDK_SRC),$(if $(wildcard $(call escspace,$(ECERE_SDK_SRC)/crossplatform.mk)),,@$(call echo,Ecere SDK Source Warning: The value of ECERE_SDK_SRC is pointing to an incorrect ($(ECERE_SDK_SRC)) location.)),)\n");
f.Puts("\t$(if $(ECERE_SDK_SRC),,$(if $(ECP_DEBUG)$(ECC_DEBUG)$(ECS_DEBUG),@$(call echo,ECC Debug Warning: Please define ECERE_SDK_SRC before using ECP_DEBUG, ECC_DEBUG or ECS_DEBUG),))\n");
//f.Puts("# PRE-BUILD COMMANDS\n");
if(options && options.prebuildCommands)
f.Puts("\t$(UPX) $(UPXFLAGS) $(TARGET)\n");
f.Puts("endif\n");
f.Puts("else\n");
+ f.Puts("ifneq \"$(TARGET_ARCH)\" \"x86_64\"");
f.Puts("\t$(UPX) $(UPXFLAGS) $(TARGET)\n");
f.Puts("endif\n");
+ f.Puts("endif\n");
}
}
if(resNode.files && resNode.files.count && !noResources)
else
f.Printf("CUSTOM%d_%s =", v-1, variableName);
f.Puts(&v ? &v : "");
- f.Puts("\n");
- f.Puts("\n");
+ f.Puts("\n\n");
break;
}
}
}
- f.Puts("\n");
}
void MatchProjectAndConfigPlatformOptions(ProjectConfig config, Platform platform,
}
}
+static inline void ProjectLoadLastBuildNamesInfo(Project prj, ProjectConfig cfg)
+{
+ if(prj.lastBuildNamesInfo)
+ {
+ prj.lastBuildNamesInfo.Free();
+ delete prj.lastBuildNamesInfo;
+ }
+ prj.lastBuildNamesInfo = { };
+ prj.topNode.GenMakefileGetNameCollisionInfo(prj.lastBuildNamesInfo, cfg);
+}
+
Project LegacyBinaryLoadProject(File f, char * filePath)
{
Project project = null;
delete project.topNode.files;
if(!project.files) project.files = { };
project.topNode.files = project.files;
+
+ {
+ char topNodePath[MAX_LOCATION];
+ GetWorkingDir(topNodePath, sizeof(topNodePath)-1);
+ MakeSlashPath(topNodePath);
+ PathCatSlash(topNodePath, filePath);
+ project.filePath = topNodePath;//filePath;
+ }
+
+ project.topNode.FixupNode(insidePath);
+
project.resNode = project.topNode.Add(project, "Resources", project.topNode.files.last, resources, archiveFile, false);
delete project.resNode.path;
project.resNode.path = project.resourcesPath;
project.resources = null;
if(!project.configurations) project.configurations = { };
- {
- char topNodePath[MAX_LOCATION];
- GetWorkingDir(topNodePath, sizeof(topNodePath)-1);
- MakeSlashPath(topNodePath);
- PathCatSlash(topNodePath, filePath);
- project.filePath = topNodePath;//filePath;
- }
-
- project.topNode.FixupNode(insidePath);
+ project.resNode.FixupNode(insidePath);
}
delete parser;
}
{
if(!project.options) project.options = { };
if(activeConfigName && activeConfigName[0] && project.configurations)
- {
- for(cfg : project.configurations)
- {
- if(!strcmpi(cfg.name, activeConfigName))
- {
- project.config = cfg;
- break;
- }
- }
- }
+ project.config = project.GetConfig(activeConfigName);
if(!project.config && project.configurations)
project.config = project.configurations.firstIterator.data;