ecere/gui/controls/ListBox: add NotifyMoved.
[sdk] / ecere / src / gui / controls / ListBox.ec
index c075102..45cf1ab 100644 (file)
@@ -52,7 +52,7 @@ extern int __ecereVMethodID_class_OnSaveEdit;
 
 private:
 
-public class DataField 
+public class DataField
 {
 public:
    property Class dataType
@@ -119,7 +119,7 @@ public:
       }
    };
    property int sortOrder { get { return this ? sortOrder : 0; } };
-   property char * header
+   property const char * header
    {
       set
       {
@@ -133,7 +133,7 @@ public:
       set
       {
          userData = value;
-      } 
+      }
       get
       {
          return this ? userData : null;
@@ -141,7 +141,7 @@ public:
    };
    property bool freeData
    {
-      set { freeData = value; } get { return freeData; }      
+      set { freeData = value; } get { return freeData; }
    };
    property DataField prev { get { return prev; } };
    property DataField next { get { return next; } };
@@ -150,9 +150,6 @@ public:
    {
       if(prev != after)
       {
-         int position = 0;
-         DataField field;
-
          listBox.fields.Move(this, after);
 
          // Fix up positions
@@ -181,12 +178,12 @@ public:
             if(cell && cell.isSet && dataType)
             {
                static char tempString[4096];
-               String string;
+               const String string;
                int tw = 0;
                if(dataType.type == normalClass || dataType.type == noHeadClass)
-                  string = (char *)dataType._vTbl[__ecereVMethodID_class_OnGetString](dataType, cell.data[0], tempString, userData, null);
+                  string = ((const char *(*)(void *, void *, char *, void *, bool *))(void *)dataType._vTbl[__ecereVMethodID_class_OnGetString])(dataType, cell.data[0], tempString, userData, null);
                else
-                  string = (char *)dataType._vTbl[__ecereVMethodID_class_OnGetString](dataType, cell.data, tempString, userData, null);
+                  string = ((const char *(*)(void *, void *, char *, void *, bool *))(void *)dataType._vTbl[__ecereVMethodID_class_OnGetString])(dataType, cell.data, tempString, userData, null);
                if(string)
                   display.FontExtent(row.header ? boldFont : font, string, strlen(string), &tw, null);
                else
@@ -223,11 +220,11 @@ private:
          listBox.fields.Remove(this);
          for(field = listBox.fields.first; field; field = field.next)
          {
-            if(field.index >= index) 
+            if(field.index >= index)
                field.index--;
          }
          if(listBox.currentField == this)
-            listBox.currentField = null;            
+            listBox.currentField = null;
          listBox.numFields--;
          listBox.OnResize(listBox.clientSize.w, listBox.clientSize.h);
          listBox = null;
@@ -235,7 +232,7 @@ private:
    }
 
    DataField prev, next;
-   char * header;
+   const char * header;
    Class dataType;
    int width;
    uint index;
@@ -258,22 +255,22 @@ public class DataRow
    bool skipCheck;
 #endif
 public:
-   property int tag { set { tag = value; } get { return tag; } };
+   property int64 tag { set { if(this) tag = value; } get { return this ? tag : 0; } };
    property DataRow previous { get { return prev; } };
    property DataRow next { get { return next; } };
    property int index { get { return (this && (!parent || parent.IsExpanded())) ? index : -1; } };
-   property char * string
+   property const char * string
    {
       set { SetData(listBox.fields.first, value); }
       get { return GetData(listBox.fields.first); }
    };
    property bool isHeader { set { header = value; } get { return this ? header : false; } };
-   property BitmapResource icon { set { icon = value; } get { return icon; } };
+   property BitmapResource icon { set { if(this) icon = value; } get { return this ? icon : null; } };
    property bool collapsed
    {
       set
       {
-         if(collapsed != value)
+         if(this && collapsed != value)
          {
             collapsed = value;
             if(parent.IsExpanded())
@@ -292,11 +289,11 @@ public:
                      if(!listBox.clickedRow)
                         listBox.clickedRow = this;
                   }
-                  if(listBox.currentRow && !listBox.currentRow.parent.IsExpanded()) 
+                  if(listBox.currentRow && !listBox.currentRow.parent.IsExpanded())
                   {
                      listBox.SetCurrentRow(this, true);
                   }
-                  if(listBox.firstRowShown && !listBox.firstRowShown.parent.IsExpanded()) 
+                  if(listBox.firstRowShown && !listBox.firstRowShown.parent.IsExpanded())
                   {
                      listBox.firstRowShown = GetPrevRow();
                      if(!listBox.firstRowShown)
@@ -313,7 +310,7 @@ public:
 
                listBox.SetScrollArea(
                   listBox.width,
-                  (listBox.rowCount * listBox.rowHeight) + 
+                  (listBox.rowCount * listBox.rowHeight) +
                   ((listBox.style.header) ? listBox.rowHeight : 0) -
                   ((!((listBox.clientSize.h+1) % listBox.rowHeight)) ? listBox.rowHeight : 0), true);
                listBox.Update(null);
@@ -321,7 +318,7 @@ public:
             }
          }
 #ifdef _DEBUG
-         if(!skipCheck)
+         if(this && !skipCheck)
             listBox.CheckConsistency();
 #endif
       }
@@ -358,14 +355,14 @@ public:
             listBox.HideEditBox(false, false, true);
 
             /*
-            if(this == listBox.clickedRow) 
+            if(this == listBox.clickedRow)
             {
                listBox.clickedRow = GetNextRow();
                if(!listBox.clickedRow)
                   listBox.clickedRow = GetPrevRow();
             }
 
-            if(this == listBox.currentRow) 
+            if(this == listBox.currentRow)
             {
                DataRow newCurrentRow = GetNextRow();
                if(!listBox.newCurrentRow)
@@ -373,7 +370,7 @@ public:
                listBox.SetCurrentRow(newCurrentRow, true);
             }
 
-            if(this == listBox.firstRowShown) 
+            if(this == listBox.firstRowShown)
             {
                listBox.firstRowShown = GetPrevRow();
                if(!listBox.firstRowShown)
@@ -401,7 +398,7 @@ public:
 #endif
             }
 
-            if(value.IsExpanded(this))
+            if(value.IsExpanded())
             {
                DataRow search;
 
@@ -423,7 +420,7 @@ public:
 
                listBox.SetScrollArea(
                   listBox.width,
-                  (listBox.rowCount * listBox.rowHeight) + 
+                  (listBox.rowCount * listBox.rowHeight) +
                   ((listBox.style.header) ? listBox.rowHeight : 0) -
                   ((!((listBox.clientSize.h+1) % listBox.rowHeight)) ? listBox.rowHeight : 0), true);
                if(listBox.style.autoScroll)
@@ -486,20 +483,19 @@ public:
          if(listBox && prev != after)
          {
             DataRow search;
-            int afterIndex = -1;
             int headerSize = ((listBox.style.header) ? listBox.rowHeight : 0);
             int height = listBox.clientSize.h + 1 - headerSize;
             int ixCount = (!collapsed && subRows.count) ? GetLastRow().index - index + 1 : 1;
 
             if(!after || after.index < index)
             {
-               if(after == listBox.firstRowShown.prev) 
+               if((after && after == listBox.firstRowShown.prev) || (!after && !parent && listBox.firstRowShown.prev))
                   listBox.firstRowShown = this;
 
                // All rows between AFTER (exclusive) and ROW (exclusive) are incremented by one
                // ROW is equal to AFTER's index + 1
 
-               for(search = after ? after.next : listBox.rows.first; search && search != this; search = search.GetNextRow())
+               for(search = after ? after.next : (parent ? parent.subRows.first : listBox.rows.first); search && search != this; search = search.GetNextRow())
                   search.index += ixCount;
 
                if(after && after.subRows.first && !after.collapsed)
@@ -508,7 +504,7 @@ public:
                   index = search.index + 1;
                }
                else
-                  index = after ? (after.index + 1) : 0;
+                  index = after ? (after.index + 1) : parent ? parent.index + 1 : 0;
 
                // Fix indices of sub rows
                if(!collapsed)
@@ -520,12 +516,12 @@ public:
             }
             else
             {
-               DataRow nextRow = GetNextRow();
+               DataRow nextRow;
+               int afterIXCount = 1;
+
+               nextRow = GetNextRow();
                if(this == listBox.firstRowShown)
-               {
                   listBox.firstRowShown = nextRow;
-                  index = after ? (after.index + 1) : 0;
-               }
 
                // All rows between ROW (exclusive) and AFTER (inclusive) are decremented by one
                // ROW is equal to AFTER's index
@@ -535,8 +531,33 @@ public:
                   search.index -= ixCount;
                   if(search == after) break;
                }
+
+               // Fix up's after's sub rows
+               if(after && !after.collapsed)
+               {
+                  DataRow last = after.GetLastRow();
+                  if(last != after)
+                  {
+                     int ix = after.index+1;
+                     for(search = after.GetNextRow(); search; search = search.GetNextRow())
+                     {
+                        afterIXCount++;
+                        search.index = ix++;
+                        if(search == last) break;
+                     }
+                  }
+               }
+               index = after.index + afterIXCount;
+
+               // Fix indices of sub rows
+               if(!collapsed)
+               {
+                  int c, ix = index+1;
+                  for(c = 1, search = GetNextRow(); search && c < ixCount; c++, search = search.GetNextRow())
+                     search.index = ix++;
+               }
             }
-            listBox.rows.Move(this, after);
+            (parent ? parent.subRows : listBox.rows).Move(this, after);
 
 #ifdef _DEBUG
             listBox.CheckConsistency();
@@ -575,7 +596,7 @@ public:
             if((field.dataType.type == normalClass || field.dataType.type == noHeadClass))
                return cell.data[0];
             else
-               return (void *)cell.data;   // Cast for MemoryGuard
+               return cell.data;
          }
       }
       return null;
@@ -595,25 +616,25 @@ public:
                if(dataType.type == normalClass || dataType.type == noHeadClass)
                {
                   if(cell.data[0] && field.freeData)
-                     dataType._vTbl[__ecereVMethodID_class_OnFree](dataType, cell.data[0]);
+                     ((void (*)(void *, void *))(void *)dataType._vTbl[__ecereVMethodID_class_OnFree])(dataType, cell.data[0]);
 
                   if(eClass_IsDerived(dataType, class(char *)) && field.freeData)
-                     dataType._vTbl[__ecereVMethodID_class_OnCopy](dataType, cell.data, newData);
+                     ((void (*)(void *, void *, void *))(void *)dataType._vTbl[__ecereVMethodID_class_OnCopy])(dataType, cell.data, newData);
                   else
                      cell.data[0] = (void *)newData;
                }
                else
                {
                   // Free old data first
-                  dataType._vTbl[__ecereVMethodID_class_OnFree](dataType, cell.data);
-                  dataType._vTbl[__ecereVMethodID_class_OnCopy](dataType, cell.data, newData);
+                  ((void (*)(void *, void *))(void *)dataType._vTbl[__ecereVMethodID_class_OnFree])(dataType, cell.data);
+                  ((void (*)(void *, void *, void *))(void *)dataType._vTbl[__ecereVMethodID_class_OnCopy])(dataType, cell.data, newData);
                }
             }
             cell.isSet = true;
             listBox.modifiedDocument = true;
             listBox.Update(null);
             if(dataType && (dataType.type == normalClass || dataType.type == noHeadClass))
-               return (void *)cell.data;     // Cast for MemoryGuard
+               return cell.data;
             else
                return &cell.data;
          }
@@ -635,13 +656,13 @@ public:
                if(dataType.type == normalClass || dataType.type == noHeadClass)
                {
                   if(cell.data[0] && field.freeData)
-                     dataType._vTbl[__ecereVMethodID_class_OnFree](dataType, cell.data[0]);
+                     ((void (*)(void *, void *))(void *)dataType._vTbl[__ecereVMethodID_class_OnFree])(dataType, cell.data[0]);
                   cell.data[0] = null;
                }
                else
                {
                   // Free old data first
-                  dataType._vTbl[__ecereVMethodID_class_OnFree](dataType, cell.data);
+                  ((void (*)(void *, void *))(void *)dataType._vTbl[__ecereVMethodID_class_OnFree])(dataType, cell.data);
                }
             }
             cell.isSet = false;
@@ -650,7 +671,7 @@ public:
       }
    }
 
-   DataRow FindRow(int tag)
+   DataRow FindRow(int64 tag)
    {
       DataRow row = null;
       for(row = subRows.first; row; row = row.next)
@@ -661,7 +682,7 @@ public:
       return row;
    }
 
-   DataRow FindSubRow(int tag)
+   DataRow FindSubRow(int64 tag)
    {
       DataRow row = null;
       for(row = subRows.first; row; row = row.next)
@@ -700,16 +721,16 @@ public:
                      break;
                if(field)
                {
-                  int size = (field.dataType && field.dataType.typeSize) ? 
+                  int size = (field.dataType && field.dataType.typeSize) ?
                      (sizeof(class ListBoxCell) + field.dataType.typeSize - sizeof(void *)) : sizeof(class ListBoxCell);
                   ListBoxCell cell = (ListBoxCell)new0 byte[size];
                   row.cells.Add(cell);
-                  FillBytes(cell.data, 0, size - (uint)&((ListBoxCell)0).data);
+                  FillBytes(cell.data, 0, size - (uint)(uintptr)&((ListBoxCell)0).data);
                   cell.isSet = false;
                }
             }
 
-            if(IsExpanded(this))
+            if(IsExpanded())
             {
                DataRow search;
 
@@ -725,11 +746,11 @@ public:
                listBox.rowCount++;
 
                for(search = row.GetNextRow(); search; search = search.GetNextRow())
-                  search.index++;            
+                  search.index++;
 
                listBox.SetScrollArea(
                   listBox.width,
-                  (listBox.rowCount * listBox.rowHeight) + 
+                  (listBox.rowCount * listBox.rowHeight) +
                   ((listBox.style.header) ? listBox.rowHeight : 0) -
                   ((!((listBox.clientSize.h+1) % listBox.rowHeight)) ? listBox.rowHeight : 0), true);
                if(listBox.style.autoScroll)
@@ -753,16 +774,16 @@ public:
       return null;
    }
 
-   DataRow AddStringf(char * format, ...)
+   DataRow AddStringf(const char * format, ...)
    {
       if(this)
       {
          DataRow row;
          char string[MAX_F_STRING];
          va_list args;
-         string[sizeof(string)-1] = 0;
          va_start(args, format);
          vsnprintf(string, sizeof(string), format, args);
+         string[sizeof(string)-1] = 0;
          va_end(args);
 
          row = AddRow();
@@ -772,7 +793,7 @@ public:
       return null;
    }
 
-   DataRow AddString(char * string)
+   DataRow AddString(const char * string)
    {
       if(this)
       {
@@ -788,7 +809,7 @@ public:
 private:
    DataRow()
    {
-      subRows.offset = (uint)&((DataRow)0).prev;
+      subRows.offset = (uint)(uintptr)&((DataRow)0).prev;
    }
 
    ~DataRow()
@@ -810,16 +831,16 @@ private:
          {
             DataField field;
             for(field = listBox.fields.first; field && field.index != cellIndex; field = field.next);
-            if(field.dataType)
+            if(field && field.dataType)
             {
                // TOCHECK: Is this check good? Will need incref/decref sometime?
                if(field.dataType.type == normalClass || field.dataType.type == noHeadClass)
                {
                   if(cell.data[0] && field.freeData)
-                     field.dataType._vTbl[__ecereVMethodID_class_OnFree](field.dataType, cell.data[0]);
+                     ((void (*)(void *, void *))(void *)field.dataType._vTbl[__ecereVMethodID_class_OnFree])(field.dataType, cell.data[0]);
                }
                else
-                  field.dataType._vTbl[__ecereVMethodID_class_OnFree](field.dataType, cell.data);
+                  ((void (*)(void *, void *))(void *)field.dataType._vTbl[__ecereVMethodID_class_OnFree])(field.dataType, cell.data);
             }
          }
          next = cell.next;
@@ -837,8 +858,8 @@ private:
       int result = 0;
       ListBoxCell cell1, cell2;
       uint index;
-      for(index = 0, cell1 = cells.first, cell2 = b.cells.first; 
-          index != sortField.index; 
+      for(index = 0, cell1 = cells.first, cell2 = b.cells.first;
+          index != sortField.index;
           index++, cell1 = cell1.next, cell2 = cell2.next);
    /*
       if(!cell1.isSet && !cell2.isSet)
@@ -856,14 +877,14 @@ private:
       {
          if(sortField.dataType.type == normalClass || sortField.dataType.type == noHeadClass)
          {
-            result = sortField.dataType._vTbl[__ecereVMethodID_class_OnCompare](sortField.dataType, 
-               (cell1.isSet && cell1.data) ? cell1.data[0] : null, 
+            result = ((int (*)(void *, void *, void *))(void *)sortField.dataType._vTbl[__ecereVMethodID_class_OnCompare])(sortField.dataType,
+               (cell1.isSet && cell1.data) ? cell1.data[0] : null,
                (cell2.isSet && cell2.data) ? cell2.data[0] : null);
          }
          else
          {
-            result = sortField.dataType._vTbl[__ecereVMethodID_class_OnCompare](sortField.dataType, 
-               cell1.isSet ? cell1.data : null, 
+            result = ((int (*)(void *, void *, void *))(void *)sortField.dataType._vTbl[__ecereVMethodID_class_OnCompare])(sortField.dataType,
+               cell1.isSet ? cell1.data : null,
                cell2.isSet ? cell2.data : null);
          }
       }
@@ -920,9 +941,9 @@ private:
    {
       DataRow row;
       // Find Next row
-      if(subRows.first && !collapsed) 
+      if(subRows.first && !collapsed)
          row = subRows.first;
-      else 
+      else
       {
          for(row = this; row; row = row.parent)
          {
@@ -942,7 +963,7 @@ private:
 
    DataRow prev, next;
    OldList cells;
-   int tag;
+   int64 tag;
    SelectedFlag selectedFlag;
    ListBox listBox;
    bool header;
@@ -966,7 +987,7 @@ public class ListBox : CommonControl
 public:
    // Properties
    property bool freeSelect { property_category $"Behavior" set { style.freeSelect = value; } get { return style.freeSelect; } };
-   property DataRow currentRow { property_category $"Private" /*"Behavior"*/ set { SetCurrentRow(value, false); } get { return currentRow; } };
+   property DataRow currentRow { property_category $"Private" /*"Behavior"*/ set { if(this) SetCurrentRow(value, false); } get { return this ? currentRow : null; } };
    property DataField currentField
    {
       get { return currentField; }
@@ -982,7 +1003,7 @@ public:
 
    property int rowHeight
    {
-      property_category $"Appearance" 
+      property_category $"Appearance"
       isset { return style.heightSet; }
       set
       {
@@ -999,11 +1020,11 @@ public:
             OnApplyGraphics();
          }
       }
-      get { return rowHeight; }
+      get { return this ? rowHeight : 0; }
    };
    property Seconds typingTimeout
    {
-      property_category $"Behavior" 
+      property_category $"Behavior"
       set
       {
          typedString[0] = '\0';
@@ -1020,7 +1041,7 @@ public:
    property bool hasClearHeader { property_category $"Appearance" set { style.clearHeader = value; if(value) property::hasHeader = true; } get { return style.clearHeader; } };
    property bool hasHeader
    {
-      property_category $"Appearance" 
+      property_category $"Appearance"
       set
       {
          if(value && !style.header)
@@ -1046,7 +1067,7 @@ public:
          style.header = value;
       }
       get { return style.header; }
-   };   
+   };
    property bool multiSelect { property_category $"Behavior" set { style.multiSelect = value; } get { return style.multiSelect; } };
    property bool alwaysEdit { property_category $"Behavior" set { style.alwaysEdit = value; } get { return style.alwaysEdit; } };
    property bool fullRowSelect { property_category $"Appearance" set { style.fullRowSelect = value; } get { return style.fullRowSelect; } };
@@ -1057,7 +1078,7 @@ public:
    property bool noDragging { property_category $"Behavior" set { style.noDragging = value; } get { return style.noDragging; } };
    property bool fillLastField
    {
-      property_category $"Behavior" 
+      property_category $"Behavior"
       set
       {
          style.fillLastField = value;
@@ -1108,8 +1129,9 @@ public:
    virtual bool Window::NotifyResized(ListBox listBox, DataField field, Modifiers mods);
    virtual bool Window::NotifyCollapse(ListBox listBox, DataRow row, bool collapsed);
    virtual bool Window::NotifyKeyHit(ListBox listBox, DataRow row, Key key, unichar ch);
-   virtual bool Window::NotifyModified(ListBox listBox, DataRow row);   
+   virtual bool Window::NotifyModified(ListBox listBox, DataRow row);
    virtual bool Window::NotifyEditing(ListBox listBox, DataRow row);
+   virtual void Window::NotifyMoved(ListBox listBox, DataRow row, Modifiers mods);
 
 #ifdef _DEBUG
    private void CheckConsistency()
@@ -1146,7 +1168,7 @@ public:
          incref addedField;
          addedField.listBox = this;
          fields.Add(addedField);
-      
+
          addedField.sortOrder = 1;
          addedField.index = numFields;
          numFields++;
@@ -1160,7 +1182,7 @@ public:
                stayOnTop = true;
                inactive = true;
                dontScrollVert = true;
-               id = (uint)addedField;
+               id = (int64)(intptr)addedField;
                text = addedField.header;
                bevel = (!guiApp.textMode && !style.clearHeader);
                ellipsis = true;
@@ -1183,16 +1205,16 @@ public:
             field = addedField;
             for(row = rows.first; row; )
             {
-               int size = (field.dataType && field.dataType.typeSize) ? 
+               int size = (field.dataType && field.dataType.typeSize) ?
                   (sizeof(class ListBoxCell) + field.dataType.typeSize - sizeof(void *)) : sizeof(class ListBoxCell);
                ListBoxCell cell = (ListBoxCell)new0 byte[size];
                row.cells.Add(cell);
-               FillBytes(cell.data, 0, size - (uint)&((ListBoxCell)0).data);
+               FillBytes(cell.data, 0, size - (uint)(uintptr)&((ListBoxCell)0).data);
                cell.isSet = false;
 
-               if(row.subRows.first) 
+               if(row.subRows.first)
                   row = row.subRows.first;
-               else 
+               else
                {
                   for(; row; row = row.parent)
                   {
@@ -1210,9 +1232,9 @@ public:
       if(this)
       {
          DataField field;
+         Clear();    // Ensure data is cleared first
          while((field = fields.first))
          {
-            //delete field;
             field.Free();
             delete field;
          }
@@ -1247,19 +1269,19 @@ public:
                      if(field.dataType.type == normalClass || field.dataType.type == noHeadClass)
                      {
                         if(cell.data[0] && field.freeData)
-                           field.dataType._vTbl[__ecereVMethodID_class_OnFree](field.dataType, cell.data[0]);
+                           ((void (*)(void *, void *))(void *)field.dataType._vTbl[__ecereVMethodID_class_OnFree])(field.dataType, cell.data[0]);
                      }
                      else
-                        field.dataType._vTbl[__ecereVMethodID_class_OnFree](field.dataType, cell.data);
+                        ((void (*)(void *, void *))(void *)field.dataType._vTbl[__ecereVMethodID_class_OnFree])(field.dataType, cell.data);
                   }
 
                   row.cells.Remove(cell);
                   delete cell;
                }
 
-               if(row.subRows.first) 
+               if(row.subRows.first)
                   row = row.subRows.first;
-               else 
+               else
                {
                   for(; row; row = row.parent)
                   {
@@ -1283,24 +1305,22 @@ public:
       if(row)
       {
          DataRow search;
-         DataField field;
-         int c;
 
          row.index = 0;
          rows.Insert(null, row);
          row.listBox = this;
 
          for(search = row.GetNextRow(); search; search = search.GetNextRow())
-            search.index++;         
+            search.index++;
 
          this.rowCount++;
          row.cells.Clear();
-         
+
          firstRowShown = row;
 
          SetScrollArea(
             width,
-            (rowCount * rowHeight) + 
+            (rowCount * rowHeight) +
             ((style.header) ? rowHeight : 0) -
             ((!((clientSize.h+1) % rowHeight)) ? rowHeight : 0), true);
          if(style.autoScroll)
@@ -1327,8 +1347,7 @@ public:
                // Find very last row
                {
                   DataRow lastRow;
-                  for(lastRow = rows.last; lastRow && !lastRow.collapsed && lastRow.subRows.last; lastRow)
-                     lastRow = lastRow.subRows.last;
+                  for(lastRow = rows.last; lastRow && !lastRow.collapsed && lastRow.subRows.last; lastRow = lastRow.subRows.last);
                   row.index = lastRow ? (lastRow.index + 1) : 0;
                }
 
@@ -1344,11 +1363,11 @@ public:
                         break;
                   if(field)
                   {
-                     int size = (field.dataType && field.dataType.typeSize) ? 
+                     int size = (field.dataType && field.dataType.typeSize) ?
                         (sizeof(class ListBoxCell) + field.dataType.typeSize - sizeof(void *)) : sizeof(class ListBoxCell);
                      ListBoxCell cell = (ListBoxCell) new0 byte[size];
                      row.cells.Add(cell);
-                     FillBytes(cell.data, 0, size - (uint)&((ListBoxCell)0).data);
+                     FillBytes(cell.data, 0, size - (uint)(uintptr)&((ListBoxCell)0).data);
                      cell.isSet = false;
                   }
                }
@@ -1361,7 +1380,7 @@ public:
                if(rowHeight)
                   SetScrollArea(
                      width,
-                     (rowCount * rowHeight) + 
+                     (rowCount * rowHeight) +
                      ((style.header) ? rowHeight : 0) -
                      ((!((clientSize.h+1) % rowHeight)) ? rowHeight : 0), true);
                if(style.autoScroll)
@@ -1401,7 +1420,7 @@ public:
             row.listBox = this;
 
             for(search = row.GetNextRow(); search; search = search.GetNextRow())
-               search.index++;         
+               search.index++;
 
             this.rowCount++;
             row.cells.Clear();
@@ -1412,11 +1431,11 @@ public:
                      break;
                if(field)
                {
-                  int size = (field.dataType && field.dataType.typeSize) ? 
+                  int size = (field.dataType && field.dataType.typeSize) ?
                      (sizeof(class ListBoxCell) + field.dataType.typeSize - sizeof(void *)) : sizeof(class ListBoxCell);
                   ListBoxCell cell = (ListBoxCell) new0 byte[size];
                   row.cells.Add(cell);
-                  FillBytes(cell.data, 0, size - (uint)&((ListBoxCell)0).data);
+                  FillBytes(cell.data, 0, size - (uint)(uintptr)&((ListBoxCell)0).data);
                   cell.isSet = false;
                }
             }
@@ -1427,7 +1446,7 @@ public:
 
             SetScrollArea(
                width,
-               (rowCount * rowHeight) + 
+               (rowCount * rowHeight) +
                ((style.header) ? rowHeight : 0) -
                ((!((clientSize.h+1) % rowHeight)) ? rowHeight : 0), true);
             if(style.autoScroll)
@@ -1442,7 +1461,7 @@ public:
       return null;
    }
 
-   DataRow AddStringf(char * format, ...)
+   DataRow AddStringf(const char * format, ...)
    {
       if(this)
       {
@@ -1450,10 +1469,10 @@ public:
 
          char string[MAX_F_STRING];
          va_list args;
-         string[sizeof(string)-1] = 0;
 
          va_start(args, format);
          vsnprintf(string, sizeof(string), format ? format : "", args);
+         string[sizeof(string)-1] = 0;
          va_end(args);
 
          row = AddRow();
@@ -1463,7 +1482,7 @@ public:
       return null;
    }
 
-   DataRow AddString(char * string)
+   DataRow AddString(const char * string)
    {
       if(this)
       {
@@ -1499,20 +1518,20 @@ public:
          if(row.parent.IsExpanded())
          {
             for(search = row.GetNextRow(); search; search = search.GetNextRow())
-               search.index--;         
+               search.index--;
             this.rowCount--;
          }
 
          HideEditBox(false, false, true);
 
-         if(row == clickedRow) 
+         if(row == clickedRow)
          {
             clickedRow = row.GetNextRow();
             if(!clickedRow)
                clickedRow = row.GetPrevRow();
          }
 
-         if(row == currentRow) 
+         if(row == currentRow)
          {
             DataRow newCurrentRow = row.GetNextRow();
             if(!newCurrentRow)
@@ -1520,7 +1539,7 @@ public:
             SetCurrentRow(newCurrentRow, true);
          }
 
-         if(row == firstRowShown) 
+         if(row == firstRowShown)
          {
             firstRowShown = row.GetPrevRow();
             if(!firstRowShown)
@@ -1534,7 +1553,7 @@ public:
 
          SetScrollArea(
             this.width,
-            (this.rowCount * rowHeight) + 
+            (this.rowCount * rowHeight) +
             ((style.header) ? rowHeight : 0) -
             ((!((clientSize.h+1) % rowHeight)) ? rowHeight : 0), true);
 
@@ -1547,7 +1566,7 @@ public:
       }
    }
 
-   DataRow FindRow(int tag)
+   DataRow FindRow(int64 tag)
    {
       if(this)
       {
@@ -1562,11 +1581,10 @@ public:
       return null;
    }
 
-   DataRow FindString(char * searchedString)
+   DataRow FindString(const char * searchedString)
    {
       DataField field;
       bool checkNextField = true;
-      int len = searchedString ? strlen(searchedString) : 0;
 
       for(field = fields.first; field; field = field.next)
       {
@@ -1580,7 +1598,7 @@ public:
                   void * data = row.GetData(field);
                   char tempString[1024] = "";
                   bool needClass = false;
-                  char * string = (char *)field.dataType._vTbl[__ecereVMethodID_class_OnGetString](field.dataType, data, tempString, null, &needClass);
+                  const char * string = ((const char *(*)(void *, void *, char *, void *, bool *))(void *)field.dataType._vTbl[__ecereVMethodID_class_OnGetString])(field.dataType, data, tempString, null, &needClass);
 
                   if(string && string[0])
                      checkNextField = false;
@@ -1594,7 +1612,7 @@ public:
       return null;
    }
 
-   DataRow FindSubString(char * subString)
+   DataRow FindSubString(const char * subString)
    {
       DataField field;
       bool checkNextField = true;
@@ -1614,7 +1632,7 @@ public:
                      void * data = row.GetData(field);
                      char tempString[1024] = "";
                      bool needClass = false;
-                     char * string = (char *)field.dataType._vTbl[__ecereVMethodID_class_OnGetString](field.dataType, data, tempString, null, &needClass);
+                     const char * string = ((const char *(*)(void *, void *, char *, void *, bool *))(void *)field.dataType._vTbl[__ecereVMethodID_class_OnGetString])(field.dataType, data, tempString, null, &needClass);
 
                      if(string && string[0])
                         checkNextField = false;
@@ -1629,13 +1647,13 @@ public:
       return null;
    }
 
-   DataRow FindSubStringi(char * subString)
+   DataRow FindSubStringi(const char * subString)
    {
       DataField field;
       bool checkNextField = true;
       int len = subString ? strlen(subString) : 0;
       DataRow result = null;
-      char * bestResult = null;
+      const char * bestResult = null;
       int bestLen = 0;
 
       if(len)
@@ -1652,7 +1670,7 @@ public:
                      void * data = row.GetData(field);
                      char tempString[1024] = "";
                      bool needClass = false;
-                     char * string = (char *)field.dataType._vTbl[__ecereVMethodID_class_OnGetString](field.dataType, data, tempString, null, &needClass);
+                     const char * string = ((const char *(*)(void *, void *, char *, void *, bool *))(void *)field.dataType._vTbl[__ecereVMethodID_class_OnGetString])(field.dataType, data, tempString, null, &needClass);
 
                      if(string && string[0])
                         checkNextField = false;
@@ -1681,7 +1699,7 @@ public:
       return result;
    }
 
-   DataRow FindSubStringAfter(DataRow after, char * subString)
+   DataRow FindSubStringAfter(DataRow after, const char * subString)
    {
       DataField field;
       bool checkNextField = true;
@@ -1701,7 +1719,7 @@ public:
                      void * data = row.GetData(field);
                      char tempString[1024] = "";
                      bool needClass = false;
-                     char * string = (char *)field.dataType._vTbl[__ecereVMethodID_class_OnGetString](field.dataType, data, tempString, null, &needClass);
+                     const char * string = ((const char *(*)(void *, void *, char *, void *, bool *))(void *)field.dataType._vTbl[__ecereVMethodID_class_OnGetString])(field.dataType, data, tempString, null, &needClass);
 
                      if(string && string[0])
                         checkNextField = false;
@@ -1716,12 +1734,12 @@ public:
       return null;
    }
 
-   DataRow FindSubRow(int tag)
+   DataRow FindSubRow(int64 tag)
    {
       if(this)
       {
          DataRow row = null;
-      
+
          for(row = rows.first; row; row = row.next)
          {
             if(!row.noneRow && row.tag == tag)
@@ -1746,10 +1764,10 @@ public:
 
          HideEditBox(false, true, false);
          editData.Destroy(0);
-               
+
          firstRowShown = currentRow = null;
          ClearEx();
-     
+
          if(master)
          {
             if(style.freeSelect)
@@ -1761,12 +1779,12 @@ public:
          if(style.alwaysEdit && currentRow)
             currentRow.Edit(currentField);
 
-      
+
          this.rowCount = 0;
-      
+
          SetScrollArea(
                this.width,
-               (this.rowCount * rowHeight) + 
+               (this.rowCount * rowHeight) +
                ((style.header) ? rowHeight : 0) -
                ((rowHeight && !((clientSize.h+1) % rowHeight)) ? rowHeight : 0), true);
          Update(null);
@@ -1840,7 +1858,7 @@ public:
       return (void *)currentRow.GetData(field);
    }
 
-   int GetTag()
+   int64 GetTag()
    {
       return currentRow ? currentRow.tag : 0;
    }
@@ -1849,8 +1867,8 @@ private:
    ListBox()
    {
       DataField defaultField { };
-      rows.offset = (uint)&((DataRow)0).prev;
-      fields.offset = (uint)&((DataField)0).prev;
+      rows.offset = (uint)(uintptr)&((DataRow)0).prev;
+      fields.offset = (uint)(uintptr)&((DataField)0).prev;
       style.fullRowSelect = true;
       style.fillLastField = true;
       style.expandOnAdd = true;
@@ -1904,7 +1922,7 @@ private:
       if(*row)
       {
          if(!*field) *field = this ? currentField : null;
-         if(!*field && this) 
+         if(!*field && this)
          {
             for(*field = fields.first; (*field).index != 0; *field = (*field).next);
          }
@@ -1924,10 +1942,9 @@ private:
    {
       if(editData && editData.visible)
       {
-         Class dataType = currentField.dataType;
-         if(save) 
+         if(save)
             editData.SaveData();
-         
+
          editData.visible = false;
          NotifyEditDone(master, this, currentRow);
 
@@ -1940,7 +1957,7 @@ private:
             int height = rowHeight - (style.alwaysEdit ? 1 : 0);
             int y = currentRow.index * rowHeight + (style.header ? rowHeight : 0);
             int x = currentField.x;
-            int width = (!currentField.next && style.fillLastField && (!hasHorzScroll || clientSize.w - currentField.x > currentField.width + EXTRA_SPACE)) ? 
+            int width = (!currentField.next && style.fillLastField && (!hasHorzScroll || clientSize.w - currentField.x > currentField.width + EXTRA_SPACE)) ?
                   clientSize.w - currentField.x : (currentField.width + EXTRA_SPACE);
 
             if(!style.alwaysEdit)
@@ -1959,9 +1976,7 @@ private:
             */
             PopupEditBox(currentField, repositionOnly);
          }
-         else
-            printf("");
-            
+
          /*else
             currentField = null;*/
       }
@@ -1969,7 +1984,7 @@ private:
 
    void SetCurrentRow(DataRow row, bool notify)
    {
-      if(currentRow != row || (currentRow && currentRow.selectedFlag == unselected))
+      if(this && (currentRow != row || (currentRow && currentRow.selectedFlag == unselected)))
       {
          int headerSize = ((style.header) ? rowHeight : 0);
          int height = clientSize.h + 1 - headerSize;
@@ -2024,6 +2039,38 @@ private:
       }
    }
 
+   void RepositionFieldEditor()
+   {
+      if(editData && editData.visible)
+      {
+         int height = rowHeight - (style.alwaysEdit ? 1 : 0);
+         int x = 0;
+         int y = currentRow.index * rowHeight + (style.header ? rowHeight : 0);
+         int width = 0;
+         DataField field;
+
+         if(style.collapse && !(style.treeBranch))
+            x += 15;
+         for(field = fields.first; field; field = field.next)
+         {
+            width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ?
+               clientSize.w - field.x : (field.width + EXTRA_SPACE);
+            if(field == currentField) break;
+            x += width;
+         }
+         if(!style.alwaysEdit)
+         {
+            editData.position = { x, y - editData.clientStart.y };
+            editData.size = { width, height + editData.clientStart.y * 2 };
+         }
+         else
+         {
+            editData.position = { x, y };
+            editData.size = { width, height };
+         }
+      }
+   }
+
    void PopupEditBox(DataField whichField, bool repositionOnly)
    {
       if((!editData || !editData.visible || currentField != whichField) && currentRow)
@@ -2035,7 +2082,7 @@ private:
             int height = rowHeight - (style.alwaysEdit ? 1 : 0);
             int x = 0;
             int y = currentRow.index * rowHeight + (style.header ? rowHeight : 0);
-            int width;
+            int width = 0;
             //void * data = currentRow.GetData(whichField);
             DataField field;
             DataRow row = null;
@@ -2046,7 +2093,7 @@ private:
 
             for(field = fields.first; field; field = field.next)
             {
-               width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ? 
+               width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ?
                   clientSize.w - field.x : (field.width + EXTRA_SPACE);
                if(field == whichField) break;
                x += width;
@@ -2063,7 +2110,7 @@ private:
                   background = dataBoxBackground;
                   foreground = dataBoxForeground;
 
-                  bool NotifyChanged(bool closingDropDown)
+                  bool NotifyChanged(DataBox dataBox, bool closingDropDown)
                   {
                      DataRow row = null;
                      DataField field = null;
@@ -2095,7 +2142,7 @@ private:
                      bool result = DataBox::OnKeyDown(key, ch);
                      if(visible && active)   // Added this check here, because we will not use enter/escape otherwise, and lose DataBox's result
                      {
-                        if((SmartKey)key == enter || (SmartKey)key == escape) 
+                        if((SmartKey)key == enter || (SmartKey)key == escape)
                            return true;
                      }
                      return result;
@@ -2161,7 +2208,7 @@ private:
          DataField field;
 
          // Fill out indent column
-         if(style.collapse && !(style.treeBranch) && rows.first)
+         if(style.collapse && !(style.treeBranch) && (style.header || rows.first))
          {
             x += 15;
             surface.SetBackground(formColor);
@@ -2180,7 +2227,7 @@ private:
          // Vertical lines
          for(field = fields.first; field; field = field.next)
          {
-            int width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ? 
+            int width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ?
                clientSize.w - field.x : (field.width + EXTRA_SPACE);
             if(field.prev && y > 0)
                surface.VLine(0, y-1, x);
@@ -2220,7 +2267,7 @@ private:
                int y1 = y + PLUSY + 4;
                int y2;
                DataRow child;
-            
+
                for(child = row.collapsed ? null : row.subRows.first; child && child != row; )
                {
                   numRows++;
@@ -2293,7 +2340,7 @@ private:
          int indent = 0;
          DataRow parent;
          Bitmap icon = row.icon ? row.icon.bitmap : null;
-         int collapseRowStart;
+         int collapseRowStart = 0;
          bool lastWasHeader = row.header;
 
          for(parent = row.parent; parent; parent = parent.parent)
@@ -2357,8 +2404,8 @@ private:
             Color colors[] = { formColor, azure, mistyRose, linen, floralWhite, lavender, lavenderBlush, lemonChiffon };
             int level = 0;
             DataRow p = row;
-            while(p = p.parent) level++;
-            background = colors[(level % (sizeof(colors)/sizeof(colors[0]))];
+            while((p = p.parent)) level++;
+            background = colors[level % (sizeof(colors)/sizeof(colors[0]))];
             surface.SetBackground(background);
             surface.Area(rowStart, y, clientSize.w, (y + rowHeight) - 1);
             foreground = branchesColor;
@@ -2406,11 +2453,11 @@ private:
             surface.SetForeground(foreground);
             surface.SetBackground(background);
 
-            class(String)._vTbl[__ecereVMethodID_class_OnDisplay](class(String), "(none)", surface, x, y - 1 + (rowHeight - fontH)/2, width - EXTRA_SPACE/2, null, Alignment::left, dataDisplayFlags);
+            ((void (*)(void *, const void *, void *, int, int, int, void *, uint, uint))(void *)class(String)._vTbl[__ecereVMethodID_class_OnDisplay])(class(String), "(none)", surface, x, y - 1 + (rowHeight - fontH)/2, width - EXTRA_SPACE/2, null, Alignment::left, dataDisplayFlags);
          }
          else
          {
-            if(!opacity) surface.TextOpacity(false);
+            if(opacity < 1) surface.TextOpacity(false);
             // Draw the rows
             for(field = fields.first; field; field = field.next)
             {
@@ -2460,9 +2507,9 @@ private:
                   surface.SetBackground(background);
 
                   if(field.dataType.type == noHeadClass || field.dataType.type == normalClass)
-                     field.dataType._vTbl[__ecereVMethodID_class_OnDisplay](field.dataType, cell.data[0], surface, x, y - 1 + (rowHeight - fontH)/2, width - EXTRA_SPACE/2, field.userData, field.alignment, dataDisplayFlags);
+                     ((void (*)(void *, void *, void *, int, int, int, void *, uint, uint))(void *)field.dataType._vTbl[__ecereVMethodID_class_OnDisplay])(field.dataType, cell.data[0], surface, x, y - 1 + (rowHeight - fontH)/2, width - EXTRA_SPACE/2, field.userData, field.alignment, dataDisplayFlags);
                   else
-                     field.dataType._vTbl[__ecereVMethodID_class_OnDisplay](field.dataType, cell.data, surface, x, y - 1 + (rowHeight - fontH)/2, width - EXTRA_SPACE/2, field.userData, field.alignment, dataDisplayFlags);
+                     ((void (*)(void *, void *, void *, int, int, int, void *, uint, uint))(void *)field.dataType._vTbl[__ecereVMethodID_class_OnDisplay])(field.dataType, cell.data, surface, x, y - 1 + (rowHeight - fontH)/2, width - EXTRA_SPACE/2, field.userData, field.alignment, dataDisplayFlags);
                }
 
                if(!isActive && dataDisplayFlags.selected && style.alwaysEdit && field.editable)
@@ -2474,6 +2521,10 @@ private:
                   foreground = this.background;
                }
 
+#ifdef _DEBUG
+               // surface.WriteTextf(x + 100, y,  "ix: %d", row.index);
+#endif
+
                x += width;// + EXTRA_SPACE;
 
                if(row.header) break;
@@ -2555,7 +2606,7 @@ private:
       if(sortField && !style.clearHeader && style.header)
       {
          DataField field = sortField;
-         int width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ? 
+         int width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ?
             clientSize.w - field.x : (field.width + EXTRA_SPACE);
          int tw = 0, th = 0;
          if(field.header)
@@ -2564,9 +2615,9 @@ private:
          {
             bool up = field.sortOrder == 1;
             int x = 4, y = 4;
-            Box clip = 
-            { 
-               field.x + 2 - scroll.x, 0, 
+            Box clip =
+            {
+               field.x + 2 - scroll.x, 0,
                field.x + width + EXTRA_SPACE - 1 - scroll.x, rowHeight
             };
             surface.Clip(&clip);
@@ -2576,7 +2627,7 @@ private:
                   x = field.x + (width + EXTRA_SPACE - tw) / 2 + tw + EXTRA_SPACE + 4;
                else
                   x = field.x + tw + EXTRA_SPACE + 4;
-             
+
                x = Min(x, field.x + width - 4);
             }
             else if(field.alignment == right)
@@ -2600,7 +2651,7 @@ private:
                   surface.PutPixel(x + 1, y + 5);
                   surface.PutPixel(x + 1, y + 3);
                   surface.PutPixel(x + 2, y + 1);
-            
+
                   surface.SetForeground(white);
                   surface.DrawLine(x + 4, y, x + 7, y + 5);
                   surface.PutPixel(x + 6, y + 5);
@@ -2616,7 +2667,7 @@ private:
                   surface.PutPixel(x + 1, y+1);
                   surface.PutPixel(x + 1, y+3);
                   surface.PutPixel(x + 2, y+5);
-            
+
                   surface.SetForeground(white);
                   surface.DrawLine(x + 4, y+6, x + 7, y+1);
                   surface.PutPixel(x + 6, y+1);
@@ -2649,13 +2700,13 @@ private:
 
       SetScrollArea(
          width,
-         (rowCount * rowHeight) + 
+         (rowCount * rowHeight) +
          ((style.header) ? rowHeight : 0) -
          ((!((clientSize.h+1) % rowHeight)) ? rowHeight : 0), true);
 
       for(field = fields.first; field; field = field.next)
       {
-         int width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ? 
+         int width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ?
             clientSize.w - field.x : (field.width + EXTRA_SPACE);
          if(style.header && field.headButton)
          {
@@ -2684,6 +2735,8 @@ private:
       {
          HideEditBox(true, false, true);
       }
+      else if(editData && editData.visible)
+         RepositionFieldEditor();
    }
 
    void AdaptToFieldWidth(DataField field, bool doScroll)
@@ -2707,11 +2760,11 @@ private:
 
    bool HeaderPushed(Button control, int x, int y, Modifiers mods)
    {
-      DataField field = (DataField)control.id;
+      DataField field = (DataField)(intptr)control.id;
       // false: dont destroy edit box
       HideEditBox(true, false, true);
       if(style.resizable && ((!field && x < RESIZE_BORDER && fields.last) ||
-         (field && x < RESIZE_BORDER && field.prev) || 
+         (field && x < RESIZE_BORDER && field.prev) ||
          (field && x >= control.clientSize.w - RESIZE_BORDER)))
       {
          if(!field)
@@ -2750,7 +2803,7 @@ private:
          x += control.position.x;
 
          // Tweak to prevent shrinking field if we're actually moving right
-         if(x - scroll.x > this.oldX && 
+         if(x - scroll.x > this.oldX &&
             this.startWidth + x - this.resizeX < field.width)
          {
             this.oldX = x - scroll.x;
@@ -2772,9 +2825,9 @@ private:
             int fieldX = 0;
             for(field = fields.first; field; field = field.next)
             {
-               fieldX += ((field.width || style.resizable) ? 
+               fieldX += ((field.width || style.resizable) ?
                   field.width : clientSize.w) + EXTRA_SPACE;
-               if(fieldX > x) 
+               if(fieldX > x)
                   break;
             }
             if(draggingField == field)
@@ -2784,7 +2837,7 @@ private:
                        field.x >= field.x + field.width + EXTRA_SPACE - clientSize.w)
                {
                   SetScrollPosition(
-                     field.x + field.width + EXTRA_SPACE - clientSize.w, 
+                     field.x + field.width + EXTRA_SPACE - clientSize.w,
                      scroll.y);
                }
                else if(field.x + field.width + EXTRA_SPACE - clientSize.w > scroll.x ||
@@ -2820,7 +2873,7 @@ private:
       }
       else if(style.resizable)
       {
-         DataField field = (DataField)control.id;
+         DataField field = (DataField)(intptr)control.id;
          if(field)
          {
             if(x < RESIZE_BORDER && field.prev)
@@ -2855,7 +2908,7 @@ private:
       if(draggingField)
       {
          bool result = true;
-         
+
          if(style.moveFields)
          {
             if(dropField)
@@ -2868,9 +2921,9 @@ private:
                x += draggingField.x;
                for(field = fields.first; field; field = field.next)
                {
-                  fieldX += ((field.width || style.resizable) ? 
+                  fieldX += ((field.width || style.resizable) ?
                      field.width : clientSize.w) + EXTRA_SPACE;
-                  if(fieldX > x) 
+                  if(fieldX > x)
                   {
                      switchField = field;
                      break;
@@ -2910,7 +2963,7 @@ private:
    {
       if(style.header && !this.dropField && style.sortable)
       {
-         DataField field = (DataField)control.id;
+         DataField field = (DataField)(intptr)control.id;
          if(sortField == field)
             field.sortOrder *= -1;
          else
@@ -2928,7 +2981,7 @@ private:
    {
       if(style.resizable)
       {
-         DataField field = (DataField)control.id;
+         DataField field = (DataField)(intptr)control.id;
          if(field)
          {
             if(x < RESIZE_BORDER && field.prev)
@@ -2966,7 +3019,7 @@ private:
 
    bool OnLoadGraphics()
    {
-      display.FontExtent(fontObject, "W", 1, null, &fontH); 
+      display.FontExtent(fontObject, "W", 1, null, &fontH);
       if(!style.heightSet)
       {
          rowHeight = Max(fontH + 2, 16) + (style.alwaysEdit ? 1 : 0);
@@ -2998,7 +3051,7 @@ private:
    {
       if(rows.first)
       {
-         if(!initSize.w && (!anchor.left.type || !anchor.right.type) /**w*/)
+         if(!initSize.w && (!anchor.left.type || !anchor.right.type) && !*w)
          {
             // Use widest item
             DataRow row;
@@ -3006,7 +3059,7 @@ private:
             Font font = fontObject;
             Font boldFont = this.boldFont.font;
             Display display = this.display;
-            
+
             for(row = rows.first; row; row = row.GetNextRow())
             {
                Bitmap icon = row.icon ? row.icon.bitmap : null;
@@ -3045,12 +3098,12 @@ private:
                      if(cell && cell.isSet && field.dataType)
                      {
                         static char tempString[4096];
-                        char * string;
+                        const char * string;
                         int tw, th;
                         if(field.dataType.type == normalClass || field.dataType.type == noHeadClass)
-                           string = (char *)field.dataType._vTbl[__ecereVMethodID_class_OnGetString](field.dataType, cell.data[0], tempString, field.userData, null);
+                           string = ((const char *(*)(void *, void *, char *, void *, bool *))(void *)field.dataType._vTbl[__ecereVMethodID_class_OnGetString])(field.dataType, cell.data[0], tempString, field.userData, null);
                         else
-                           string = (char *)field.dataType._vTbl[__ecereVMethodID_class_OnGetString](field.dataType, cell.data, tempString, field.userData, null);
+                           string = ((const char *(*)(void *, void *, char *, void *, bool *))(void *)field.dataType._vTbl[__ecereVMethodID_class_OnGetString])(field.dataType, cell.data, tempString, field.userData, null);
                         /* GCC-4.4 Bug!
                        if(!string) string = "";
                         display.FontExtent(row.header ? boldFont : font, string, strlen(string), &tw, &th);
@@ -3127,7 +3180,7 @@ private:
 
          for(field = fields.first; field; field = field.next)
          {
-            int width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ? 
+            int width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ?
                clientSize.w - field.x : (field.width + EXTRA_SPACE);
 
             if(field.prev)
@@ -3144,7 +3197,7 @@ private:
 
       if((editData && editData.visible) || (style.alwaysEdit))
          return true;
-      
+
       if(x == MAXINT && y == MAXINT)
       {
          x = this.mouseX;
@@ -3163,18 +3216,18 @@ private:
          mouseY = y;
 
          if(this.dragging &&
-            ((vertScroll && vertScroll.visible && 
+            ((vertScroll && vertScroll.visible &&
              (y < 0 || y >= clientSize.h)) ||
-             (horzScroll && horzScroll.visible && 
+             (horzScroll && horzScroll.visible &&
              (x < 0 || x >= clientSize.w))))
          {
             timer.Start();
             if(isTimer)
             {
-               if(vertScroll && vertScroll.visible && 
+               if(vertScroll && vertScroll.visible &&
                   (y < 0 || y >= clientSize.h))
                   vertScroll.Action((y<0)?up:down, 0, 0);
-               if(horzScroll && horzScroll.visible && 
+               if(horzScroll && horzScroll.visible &&
                   (x < 0 || x >= clientSize.w))
                   horzScroll.Action((x<0)?up:down, 0, 0);
             }
@@ -3205,7 +3258,7 @@ private:
                {
                   DataRow thisRow;
                   for(thisRow = rows.first; thisRow; thisRow = thisRow.GetNextRow())
-                     if((thisRow.selectedFlag == selected || thisRow.selectedFlag == tempSelected) || 
+                     if((thisRow.selectedFlag == selected || thisRow.selectedFlag == tempSelected) ||
                         thisRow == row)
                         break;
                   if(thisRow != row)
@@ -3319,7 +3372,7 @@ private:
 
          for(field = fields.first; field; field = field.next)
          {
-            int width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ? 
+            int width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ?
                clientSize.w - field.x : (field.width + EXTRA_SPACE);
 
             if(field.prev)
@@ -3345,7 +3398,6 @@ private:
          int rowIndex = firstRowShown ? firstRowShown.index : -1;
          DataRow previousRow = currentRow;
          DataRow newCurrentRow = null;
-         DataField newCurrentField = null;
          bool moveMultiple = false;
          int numSelected = 0;
          int rowStart = -scroll.x;
@@ -3373,7 +3425,7 @@ private:
          for(row = firstRowShown; row; row = row.GetNextRow(), rowIndex ++)
          {
             rowY += rowHeight;
-            if(rowY > y || (style.multiSelect && !row.GetNextRow())) 
+            if(rowY > y || (style.multiSelect && !row.GetNextRow()))
             {
                int plusIndent = 0;
                if(style.treeBranch)
@@ -3389,7 +3441,7 @@ private:
                if(style.collapse && row.subRows.first && (row.parent || !(style.treeBranch) || (style.rootCollapse)) &&
                   (x >= rowStart + 3 + plusIndent && y >= rowY - rowHeight + PLUSY && x <= rowStart + 11 + plusIndent && y <= rowY - rowHeight + PLUSY + 8))
                */
-               if(style.collapse && 
+               if(style.collapse &&
                   (x >= rowStart && y >= rowY - rowHeight && x <= rowStart + 18 + plusIndent && y <= rowY + rowHeight-1))
                {
                   if(row.subRows.first && (row.parent || !(style.treeBranch) || (style.rootCollapse)) && x >= plusIndent)
@@ -3413,7 +3465,7 @@ private:
                         clickedRow = row;
                         //this.clickedRowIndex = rowIndex;
                      }
-                     else if(style.moveRows && !(mods.shift) && 
+                     else if(style.moveRows && !(mods.shift) &&
                         (row.selectedFlag == selected || row.selectedFlag == tempSelected) &&
                         !right && !(mods.isActivate))
                         moveMultiple = true;
@@ -3460,7 +3512,7 @@ private:
                                     {
                                        if(selRow != clickedRow)
                                        {
-                                          if(selRow.selectedFlag) 
+                                          if(selRow.selectedFlag)
                                              selRow.selectedFlag = tempUnselected;
                                           else
                                              selRow.selectedFlag = tempSelected;
@@ -3585,7 +3637,7 @@ private:
 
          if(style.freeSelect)
             NotifyHighlight(master, this, currentRow, mods);
-         else if((moveMultiple || (!(style.multiSelect) && previousRow == currentRow)) && 
+         else if((moveMultiple || (!(style.multiSelect) && previousRow == currentRow)) &&
             newCurrentRow && !(mods.shift))
          {
             if(!right)
@@ -3615,19 +3667,19 @@ private:
 
                      for(field = fields.first; field; field = field.next)
                      {
-                        int width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ? 
+                        int width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ?
                            clientSize.w - field.x : (field.width + EXTRA_SPACE);
 
                         if(!field.prev) width -= indent;
                         if(x >= sx && x < sx + width)
-                           break;                     
+                           break;
                         sx += width;
                      }
                      if(field == currentField)
                         editData.Deactivate();
                      else
                      {
-                        currentRow.Edit(field);                     
+                        currentRow.Edit(field);
                         editData.Activate();
                      }
                   }
@@ -3643,14 +3695,12 @@ private:
                   // activate it
                   if(editData && editData.visible && newCurrentRow)
                   {
-                     DataField field, whichField;
+                     DataField field;
                      int sx = -scroll.x;
                      int indent = 0;
 
                      if(style.collapse && !(style.treeBranch))
                         sx += 15;
-                  
-                     whichField = currentField;
 
                      {
                         DataRow parent;
@@ -3662,7 +3712,7 @@ private:
 
                      for(field = fields.first; field; field = field.next)
                      {
-                        int width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ? 
+                        int width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ?
                            clientSize.w - field.x : (field.width + EXTRA_SPACE);
                         if(!field.prev) width -= indent;
                         if(x >= sx && x < sx + width && newCurrentRow)
@@ -3687,8 +3737,7 @@ private:
          }
          else
          {
-            result = NotifySelect(master, this, 
-               currentRow ? currentRow : null, mods);
+            DataField f = null;
             if(result && style.alwaysEdit && currentRow)
             {
                if(newCurrentRow)
@@ -3708,19 +3757,25 @@ private:
 
                   for(field = fields.first; field; field = field.next)
                   {
-                     int width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ? 
+                     int width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ?
                         clientSize.w - field.x : (field.width + EXTRA_SPACE);
 
                      if(!field.prev) width -= indent;
                      if(x >= sx && x < sx + width)
                      {
-                        currentField = field;
+                        f = currentField = field;
                         break;
                      }
                      sx += width;
                   }
                }
-               currentRow.Edit(currentField);
+            }
+            // Moved NotifySelect after setting currentField for the NotifySelect implementation to be aware of which field is now selected (e.g. WatchesView)
+            result = NotifySelect(master, this, currentRow, mods);
+            if(result && style.alwaysEdit && currentRow)
+            {
+               // In case the user specifically clicked on a field (f is set), override any change to currentField that NotifySelect could have done
+               currentRow.Edit(f ? f : currentField);
 
                // If the user clicked exactly on the edited field,
                // activate it
@@ -3792,7 +3847,7 @@ private:
          for(row = firstRowShown; row; row = row.GetNextRow())
          {
             rowY += rowHeight;
-            if(rowY > y) 
+            if(rowY > y)
             {
                switchRow = row;
                break;
@@ -3805,14 +3860,14 @@ private:
             int fieldX = 0;
             for(field = fields.first; field; field = field.next)
             {
-               int width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ? 
+               int width = (!field.next && style.fillLastField && (!hasHorzScroll || clientSize.w - field.x > field.width + EXTRA_SPACE)) ?
                   clientSize.w - field.x : (field.width + EXTRA_SPACE);
                fieldX += width;
 
-               if(fieldX > x + scroll.x) 
+               if(fieldX > x + scroll.x)
                   break;
             }
-            
+
             if(field && field.editable)
             {
                // true: destroy edit box
@@ -3855,7 +3910,7 @@ private:
                clickedRow = row;
             }
             else
-            { 
+            {
                if(style.multiSelect)
                {
                   if(!switchRow.selectedFlag)
@@ -3897,14 +3952,44 @@ private:
                   // Switch row first: move before
                   if(row == switchRow)
                   {
-                     if(NotifyMove(master, this, switchRow.prev, mods))
-                        dragRow.Move(switchRow.prev);
+                     DataRow actualMoveRow;
+
+                     if(!switchRow.prev && switchRow.parent == dragRow.parent)
+                        actualMoveRow = null;
+                     else
+                     {
+                        actualMoveRow = switchRow.prev ? switchRow.prev : switchRow;
+                        while(actualMoveRow && actualMoveRow.parent != dragRow.parent && actualMoveRow.parent)
+                           actualMoveRow = actualMoveRow.parent;
+                     }
+
+                     if(!actualMoveRow || (actualMoveRow && actualMoveRow.parent == dragRow.parent))
+                        if(NotifyMove(master, this, actualMoveRow, mods))
+                        {
+                           dragRow.Move(actualMoveRow);
+                           NotifyMoved(master, this, actualMoveRow, mods);
+                        }
                   }
                   // Dragged row first: move after
                   else
                   {
-                     if(NotifyMove(master, this, switchRow, mods))
-                        dragRow.Move(switchRow);
+                     DataRow actualMoveRow = switchRow;
+                     DataRow nextRow = switchRow.GetNextRow();
+
+                     while(nextRow && nextRow.parent != dragRow.parent)
+                        nextRow = nextRow.parent ? nextRow.parent.next : null;
+                     if(nextRow)
+                        actualMoveRow = nextRow.prev;
+
+                     if(!nextRow)
+                        actualMoveRow = dragRow.parent ? dragRow.parent.subRows.last : rows.last;
+
+                     if(!actualMoveRow || (actualMoveRow != dragRow && actualMoveRow.parent == dragRow.parent))
+                        if(NotifyMove(master, this, actualMoveRow, mods))
+                        {
+                           dragRow.Move(actualMoveRow);
+                           NotifyMoved(master, this, actualMoveRow, mods);
+                        }
                   }
                }
             }
@@ -3960,7 +4045,7 @@ private:
       for(row = firstRowShown; row; row = row.GetNextRow())
       {
          rowY += rowHeight;
-         if(rowY > y || (style.multiSelect && !row.GetNextRow())) 
+         if(rowY > y || (style.multiSelect && !row.GetNextRow()))
          {
             if(style.treeBranch)
             {
@@ -4023,13 +4108,13 @@ private:
             bool looped = false;
             if(len == 1 && currentRow)
                startRow = (next = startRow.GetNextRow(), (next ? next : rows.first));
-        
+
             for(row = startRow; row != startRow || !looped; next = row.GetNextRow(), row = next ? next : rows.first)
             {
                void * data = row.GetData(field);
                char tempString[1024] = "";
                bool needClass = false;
-               char * string = data ? (char *)field.dataType._vTbl[__ecereVMethodID_class_OnGetString](field.dataType, data, tempString, null, &needClass) : null;
+               const char * string = data ? ((const char *(*)(void *, void *, char *, void *, bool *))(void *)field.dataType._vTbl[__ecereVMethodID_class_OnGetString])(field.dataType, data, tempString, null, &needClass) : null;
 
                if(string && string[0])
                   checkNextField = false;
@@ -4038,16 +4123,10 @@ private:
                   if(style.multiSelect)
                   {
                      DataRow selRow;
-                     bool foundRow = false;
 
-                     //this.clickedRowIndex = 0;
                      clickedRow = row;
                      for(selRow = rows.first; selRow; selRow = selRow.GetNextRow())
-                     {
-                        if(selRow == row) foundRow = true;
                         selRow.selectedFlag = unselected;
-                        //if(!foundRow) this.clickedRowIndex++;
-                     }
                      row.selectedFlag = selected;
                   }
                   SetCurrentRow(row, true);
@@ -4105,10 +4184,10 @@ private:
             draggingField = null;
             Update(null);
             return false;
-         }      
+         }
       }
 
-      if(!currentField || !currentField.editable)            
+      if(!currentField || !currentField.editable)
          for(field = fields.first; field; field = field.next)
          {
             if(field.editable)
@@ -4117,17 +4196,28 @@ private:
                break;
             }
          }
-      if(key == f2 && currentField && currentField.editable)
+      if((key == f2 || (style.alwaysEdit && (key == ctrlV || key == ctrlC || key == ctrlX || key == shiftInsert || key == ctrlInsert || key == shiftDel))) &&
+            currentField && currentField.editable)
       {
          PopupEditBox(currentField, false);
          if(editData && editData.visible)
          {
             if(style.alwaysEdit)
+            {
                editData.Activate();
+               if(key == ctrlV || key == ctrlC || key == ctrlX || key == shiftInsert || key == ctrlInsert || key == shiftDel)
+               {
+                  editData.OnKeyHit(key, ch);
+                  StopEditing(true);
+               }
+               else
+                  // For Installer to pop up file dialog
+                  NotifyKeyDown(master, this, currentRow, key, ch);
+            }
             return false;
          }
       }
+
       if(!NotifyKeyDown(master, this, currentRow, key, ch))
          return false;
 
@@ -4138,8 +4228,8 @@ private:
             return editData.OnKeyDown(key, ch);
          return true;   // We want to pick up the OnKeyHit to replace contents, but skip GoToLetter
       }
-      
-      if(ch != 128 && !key.alt && !key.ctrl && GoToLetter(ch, false))
+
+      if(ch >=32 && ch != 128 && !key.alt && !key.ctrl && GoToLetter(ch, false))
       {
          /*if(inactive && window.state != Hidden)
             NotifyHighlight(master, this, currentRow, 0);
@@ -4185,7 +4275,7 @@ private:
          }
       }
 
-      if(editData && editData.visible && ch && !key.alt && !key.ctrl && editData.active)
+      if(editData && editData.visible && ch && !key.alt && !key.ctrl && editData.active && (key.code != tab || (editData._class == class(EditBox) && ((EditBox)editData).tabKey)))
          return false;
 
       if(!key.alt && (style.multiSelect || !key.ctrl))
@@ -4436,7 +4526,7 @@ private:
       if(!NotifyKeyHit(master, this, currentRow, key, ch))
          return false;
 
-      if(ch != 128 && !key.alt && !key.ctrl && GoToLetter(ch, true))
+      if(ch >=32 && ch != 128 && !key.alt && !key.ctrl && GoToLetter(ch, true))
       {
          /*if(inactive && window.state != Hidden)
             return NotifyHighlight(master, this, currentRow, 0);
@@ -4480,7 +4570,7 @@ private:
    int rowCount;
    int rowHeight;
    int fontH;
-   double typingTimeOut;
+   public double typingTimeOut;
    char * typedString;
 
    int mouseX, mouseY;
@@ -4506,7 +4596,7 @@ private:
    {
       delay = 0.5; // typingTimeOut
       userData = this;
-      
+
       bool DelayExpired()
       {
          typedString[0] = '\0';
@@ -4545,6 +4635,6 @@ private:
 
    // Only used for OnMouseMove so far, for avoiding problems with consequential mouse moves
    bool insideNotifySelect;
-   Color selectionColor, selectionText, stippleColor;
+   ColorAlpha selectionColor, selectionText, stippleColor;
    stippleColor = 0xFFFFFF80;
 };